zeroshade opened a new pull request, #449:
URL: https://github.com/apache/arrow-go/pull/449

   fixes #448
   
   ### Rationale for this change
   When dealing with unicode in json values, `RecordFromJSON` seems to have a 
significant performance slow-down due to an odd interaction of decoders with 
goccy/go-json. `NewJSONReader` doesn't exhibit the issue because it essentially 
creates a NewDecoder for each line/record by decoding into a RecordBuilder 
directly. 
   
   ### What changes are included in this PR?
   Change `RecordFromJSON` to work closer to `NewJSONReader` in how it decodes 
directly into a `RecordBuilder` so that we side-step the performance problem 
for large amounts of JSON.
   
   ### Are these changes tested?
   Yes, benchmarks are added to keep track of the performance of using 
`RecordFromJSON` vs `NewJSONReader` for the same data.
   
   ### Are there any user-facing changes?
   Only a performance improvement when JSON has large amounts of unicode data.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to