rok commented on code in PR #12865:
URL: https://github.com/apache/arrow/pull/12865#discussion_r2229448992
##########
cpp/src/arrow/compute/kernels/scalar_temporal_test.cc:
##########
@@ -1979,6 +2003,16 @@ TEST_F(ScalarTemporalTest,
TestAssumeTimezoneNonexistent) {
&options_earliest);
}
+TEST_F(ScalarTemporalTest, StrftimeOffsetTimezone) {
+ auto options_ymdhms = StrftimeOptions("%Y-%m-%dT%H:%M:%S");
+
+ const char* seconds = R"(["1970-01-01T01:59:00", "2021-08-18T16:12:00",
null])";
+ const char* seconds_offset = R"(["1970-01-01T03:00:00",
"2021-08-18T17:13:00", null])";
+
+ CheckScalarUnary("strftime", timestamp(TimeUnit::SECOND, "+01:01"), seconds,
utf8(),
Review Comment:
Thanks for checking with colleagues! Some reviewers are on holidays right
now, but I think this could realistically make it into the next release
(September-ish timeframe).
> Minute resolution makes sense given the format +XX:XX. Users would be
responsible for handling values downstream. Values that aren't in 15min
increments simply wouldn't match any "named IANA time zone"
Yeah, I think it's good as is now and hope it won't lead to footguns :D.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
