lidavidm commented on code in PR #3199: URL: https://github.com/apache/arrow-adbc/pull/3199#discussion_r2230110154
########## docs/source/go/driver_manager.rst: ########## @@ -0,0 +1,81 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +.. or more contributor license agreements. See the NOTICE file +.. distributed with this work for additional information +.. regarding copyright ownership. The ASF licenses this file +.. to you under the Apache License, Version 2.0 (the +.. "License"); you may not use this file except in compliance +.. with the License. You may obtain a copy of the License at +.. +.. http://www.apache.org/licenses/LICENSE-2.0 +.. +.. Unless required by applicable law or agreed to in writing, +.. software distributed under the License is distributed on an +.. "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +.. KIND, either express or implied. See the License for the +.. specific language governing permissions and limitations +.. under the License. + +============== +Driver Manager +============== + +The driver manager is a package that provides bindings to the ADBC Go +API. It delegates to dynamically-loaded drivers. This allows Review Comment: Hmm, should this be more like "The driver manager is a package that implements the ADBC Go API by delegating to dynamically-loaded drivers"? ########## docs/source/go/index.rst: ########## @@ -0,0 +1,29 @@ + +.. Licensed to the Apache Software Foundation (ASF) under one +.. or more contributor license agreements. See the NOTICE file +.. distributed with this work for additional information +.. regarding copyright ownership. The ASF licenses this file +.. to you under the Apache License, Version 2.0 (the +.. "License"); you may not use this file except in compliance +.. with the License. You may obtain a copy of the License at +.. +.. http://www.apache.org/licenses/LICENSE-2.0 +.. +.. Unless required by applicable law or agreed to in writing, +.. software distributed under the License is distributed on an +.. "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +.. KIND, either express or implied. See the License for the +.. specific language governing permissions and limitations +.. under the License. + +== +Go +== + +.. toctree:: + :maxdepth: 2 + + quickstart + driver_manager + `API Reference`_ + Go API Reference <https://pkg.go.dev/github.com/apache/arrow-adbc/go/adbc> Review Comment: What is the first "API Reference" supposed to link to? ########## docs/source/go/driver_manager.rst: ########## @@ -0,0 +1,81 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +.. or more contributor license agreements. See the NOTICE file +.. distributed with this work for additional information +.. regarding copyright ownership. The ASF licenses this file +.. to you under the Apache License, Version 2.0 (the +.. "License"); you may not use this file except in compliance +.. with the License. You may obtain a copy of the License at +.. +.. http://www.apache.org/licenses/LICENSE-2.0 +.. +.. Unless required by applicable law or agreed to in writing, +.. software distributed under the License is distributed on an +.. "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +.. KIND, either express or implied. See the License for the +.. specific language governing permissions and limitations +.. under the License. + +============== +Driver Manager +============== + +The driver manager is a package that provides bindings to the ADBC Go +API. It delegates to dynamically-loaded drivers. This allows +applications to use multiple drivers simultaneously, and decouple +themselves from the specific driver. + +TODO: Should we say anything special about the Golang driver manager impl here? Review Comment: It's "just" a wrapper around the C++ driver manager ########## docs/source/go/driver_manager.rst: ########## @@ -0,0 +1,81 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +.. or more contributor license agreements. See the NOTICE file +.. distributed with this work for additional information +.. regarding copyright ownership. The ASF licenses this file +.. to you under the Apache License, Version 2.0 (the +.. "License"); you may not use this file except in compliance +.. with the License. You may obtain a copy of the License at +.. +.. http://www.apache.org/licenses/LICENSE-2.0 +.. +.. Unless required by applicable law or agreed to in writing, +.. software distributed under the License is distributed on an +.. "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +.. KIND, either express or implied. See the License for the +.. specific language governing permissions and limitations +.. under the License. + +============== +Driver Manager +============== + +The driver manager is a package that provides bindings to the ADBC Go +API. It delegates to dynamically-loaded drivers. This allows +applications to use multiple drivers simultaneously, and decouple +themselves from the specific driver. Review Comment: and also use drivers not written in Go -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
