yu-iskw commented on code in PR #3174:
URL: https://github.com/apache/arrow-adbc/pull/3174#discussion_r2230719018
##########
go/adbc/driver/bigquery/connection.go:
##########
@@ -248,6 +258,35 @@ type bigQueryTokenResponse struct {
TokenType string `json:"token_type"`
}
+// bigqueryClientFactory is an interface for creating BigQuery clients.
+// This is used for mocking in tests.
+type bigqueryClientFactory interface {
+ NewClient(ctx context.Context, projectID string, opts
...option.ClientOption) (*bigquery.Client, error)
+ EnableStorageReadClient(ctx context.Context, client *bigquery.Client,
opts ...option.ClientOption) error
Review Comment:
Alright. I have removed the abstraction.
##########
go/adbc/driver/bigquery/connection.go:
##########
@@ -248,6 +258,35 @@ type bigQueryTokenResponse struct {
TokenType string `json:"token_type"`
}
+// bigqueryClientFactory is an interface for creating BigQuery clients.
+// This is used for mocking in tests.
+type bigqueryClientFactory interface {
+ NewClient(ctx context.Context, projectID string, opts
...option.ClientOption) (*bigquery.Client, error)
+ EnableStorageReadClient(ctx context.Context, client *bigquery.Client,
opts ...option.ClientOption) error
Review Comment:
@lidavidm Alright. I have removed the abstraction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
