andishgar commented on code in PR #47164:
URL: https://github.com/apache/arrow/pull/47164#discussion_r2231567980
##########
cpp/src/arrow/table.h:
##########
@@ -207,7 +207,8 @@ class ARROW_EXPORT Table {
///
/// Two tables can be equal only if they have equal schemas.
/// However, they may be equal even if they have different chunkings.
- bool Equals(const Table& other, bool check_metadata = false) const;
+ bool Equals(const Table& other, bool check_metadata = false,
+ const EqualOptions& = EqualOptions::Defaults()) const;
Review Comment:
> Ah, sorry. I forgot about it.
>
> How about working on #46835 before this? We can revisit this with #46835
improvement.
My solution for issue #46835 is almost ready. However, when
`arrow::EqualOptions` is enabled, we should handle the case of comparing memory
references to prevent incorrect NaN comparisons. This is already handled in
`arrow::Table::Equals` under the assumption that comparing floating-point
values should behave like comparing integers. The solution to that issue is
included in this PR. Therefore, should we finish this PR first, or incorporate
its solution into the PR related to #46835?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
