singh1203 commented on code in PR #46129:
URL: https://github.com/apache/arrow/pull/46129#discussion_r2234806258
##########
cpp/src/arrow/array/validate.cc:
##########
@@ -569,7 +570,8 @@ struct ValidateArrayImpl {
} else {
actual_null_count = 0;
}
- if (actual_null_count != data.null_count) {
+ if (data.null_count != kUnknownNullCount &&
Review Comment:
Well this line ensures `actual_null_count == 0` when `nullable == false` .
##########
cpp/src/arrow/array/validate.cc:
##########
@@ -569,7 +570,8 @@ struct ValidateArrayImpl {
} else {
actual_null_count = 0;
}
- if (actual_null_count != data.null_count) {
+ if (data.null_count != kUnknownNullCount &&
Review Comment:
@pitrou Well this line ensures `actual_null_count == 0` when `nullable ==
false` .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
