zeroshade commented on code in PR #453:
URL: https://github.com/apache/arrow-go/pull/453#discussion_r2237309999
##########
arrow/compute/exec/utils.go:
##########
@@ -51,14 +51,14 @@ func GetSpanOffsets[T int32 | int64](span *ArraySpan, i
int) []T {
return ret[span.Offset:]
}
-func Min[T constraints.Ordered](a, b T) T {
+func Min[T cmp.Ordered](a, b T) T {
if a < b {
return a
}
return b
}
-func Max[T constraints.Ordered](a, b T) T {
+func Max[T cmp.Ordered](a, b T) T {
if a > b {
return a
}
Review Comment:
I need to get around to removing these entirely and just using the updated
built-ins.... but that doesn't have to happen for this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
