jecsand838 commented on code in PR #8006:
URL: https://github.com/apache/arrow-rs/pull/8006#discussion_r2244481107
##########
arrow-avro/src/reader/mod.rs:
##########
@@ -520,20 +498,13 @@ impl ReaderBuilder {
self.writer_schema_store.as_ref(),
self.reader_schema.as_ref(),
self.active_fingerprint.as_ref(),
- self.static_store_mode,
) {
- (Some(_), None, _, _) => Err(ArrowError::ParseError(
+ (Some(_), None, _) => Err(ArrowError::ParseError(
"Reader schema must be set when writer schema store is
provided".into(),
)),
- (None, _, Some(_), _) => Err(ArrowError::ParseError(
+ (None, _, Some(_)) => Err(ArrowError::ParseError(
"Active fingerprint requires a writer schema store".into(),
)),
- (None, _, _, true) => Err(ArrowError::ParseError(
- "static_store_mode=true requires a writer schema store".into(),
- )),
- (Some(_), _, None, true) => Err(ArrowError::ParseError(
- "static_store_mode=true requires an active fingerprint".into(),
- )),
_ => Ok(()),
Review Comment:
I pushed up those improvements and included a truth table in the comments.
Really good idea.
Also I removed the `self.validate()?;` call from the `ReaderBuilder::build`
method since it's only really needed in `ReaderBuilder::build_decoder`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
