mapleFU commented on code in PR #47242:
URL: https://github.com/apache/arrow/pull/47242#discussion_r2250298049
##########
cpp/src/parquet/types.cc:
##########
@@ -750,8 +750,9 @@ bool LogicalType::is_valid() const {
}
bool LogicalType::is_invalid() const { return !is_valid(); }
bool LogicalType::is_nested() const {
- return (impl_->type() == LogicalType::Type::LIST) ||
- (impl_->type() == LogicalType::Type::MAP);
+ return impl_->type() == LogicalType::Type::LIST ||
+ impl_->type() == LogicalType::Type::MAP ||
+ impl_->type() == LogicalType::Type::VARIANT;
Review Comment:
```c++
// For backward compatibility, assign equivalent legacy converted type (if
possible)
```
I don't think it's legacy... Should we split a new branch?
```
if (logical_type_->is_variant()) {
} else if (...)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
