kylebarron commented on code in PR #8065:
URL: https://github.com/apache/arrow-rs/pull/8065#discussion_r2257429928
##########
arrow-array/src/array/byte_array.rs:
##########
@@ -304,6 +304,10 @@ impl<T: ByteArrayType> GenericByteArray<T> {
}
/// Returns the element at index `i`
+ ///
+ /// Note: This method does not check for nulls and the value is arbitrary
+ /// (but still valid) if [`is_null`](Self::is_null) returns true for the
index.
Review Comment:
Since the opposite of `is_null` is `is_valid`, I'd call this well-defined,
not `valid`
```suggestion
/// (but still well-defined) if [`is_null`](Self::is_null) returns true
for the index.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
