raulcd commented on code in PR #47261:
URL: https://github.com/apache/arrow/pull/47261#discussion_r2257643702
##########
.github/workflows/cpp_extra.yml:
##########
@@ -124,6 +124,12 @@ jobs:
-e ARROW_USE_MESON=ON
runs-on: ubuntu-latest
title: AMD64 Ubuntu Meson
+ - continue-on-error: true
Review Comment:
isn't it better if it's just marked as failure and we just accept it to fail?
At the moment it gives the false positive that the job is successful when it
is indeed failing:
```
[1963/2035] Building CXX object
src/gandiva/CMakeFiles/gandiva-internals-test.dir/cache_test.cc.o
FAILED: src/gandiva/CMakeFiles/gandiva-internals-test.dir/cache_test.cc.o
/usr/bin/ccache /usr/bin/c++ -DARROW_HAVE_RUNTIME_AVX2
-DARROW_HAVE_RUNTIME_AVX512 -DARROW_HAVE_RUNTIME_BMI2
-DARROW_HAVE_RUNTIME_SSE4_2 -DARROW_HAVE_SSE4_2
-DGANDIVA_EXTENSION_TEST_DIR=\"/build/cpp/src/gandiva/tests/external_functions\"
-I/build/cpp/src -I/arrow/cpp/src -I/arrow/cpp/src/generated -isystem
/usr/lib/llvm-18/include -Wredundant-move -Wno-noexcept-type
-fdiagnostics-color=always -Wall -Wno-conversion -Wno-sign-conversion
-Wdate-time -Wimplicit-fallthrough -Wunused-result -fno-semantic-interposition
-msse4.2 -g -Werror -O0 -ggdb -g1 -fPIE -DGTEST_HAS_PTHREAD=1 -std=c++23 -MD
-MT src/gandiva/CMakeFiles/gandiva-internals-test.dir/cache_test.cc.o -MF
src/gandiva/CMakeFiles/gandiva-internals-test.dir/cache_test.cc.o.d -o
src/gandiva/CMakeFiles/gandiva-internals-test.dir/cache_test.cc.o -c
/arrow/cpp/src/gandiva/cache_test.cc
In file included from /arrow/cpp/src/gandiva/cache_test.cc:18:
/arrow/cpp/src/gandiva/cache.h: In instantiation of 'ValueType
gandiva::Cache<KeyType, ValueType>::GetObjectCode(const KeyType&) [with KeyType
= gandiva::TestCacheKey; ValueType = std::__cxx11::basic_string<char>]':
/arrow/cpp/src/gandiva/cache_test.cc:41:3: required from here
/arrow/cpp/src/gandiva/cache.h:54:35: error: use of deleted function
'std::__cxx11::basic_string<_CharT, _Traits,
_Alloc>::basic_string(std::nullptr_t) [with _CharT = char; _Traits =
std::char_traits<char>; _Alloc = std::allocator<char>; std::nullptr_t =
std::nullptr_t]'
54 | return result != std::nullopt ? *result : nullptr;
| ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~
In file included from /usr/include/c++/12/string:53,
from /usr/include/c++/12/stdexcept:39,
from /usr/include/c++/12/system_error:41,
from /usr/include/c++/12/mutex:41,
from /arrow/cpp/src/gandiva/cache.h:21:
/usr/include/c++/12/bits/basic_string.h:734:7: note: declared here
734 | basic_string(nullptr_t) = delete;
| ^~~~~~~~~~~~
[1964/2035] Linking CXX shared library debug/libgandiva.so.2200.0.0
[1965/2035] Building CXX object
src/gandiva/CMakeFiles/gandiva-internals-test.dir/bitmap_accumulator_test.cc.o
[1966/2035] Building CXX object
src/gandiva/CMakeFiles/gandiva-internals-test.dir/function_registry_test.cc.o
[1967/2035] Building CXX object
src/gandiva/CMakeFiles/gandiva-internals-test.dir/engine_llvm_test.cc.o
ninja: build stopped: subcommand failed.
real 29m16.154s
user 108m4.086s
sys 8m5.864s
Error: `docker compose
--file=/home/runner/work/arrow/arrow/docker-compose.yml run --rm -e
CMAKE_CXX_STANDARD=23 debian-cpp` exited with a non-zero exit code 1, see the
process log above.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
