hiroyuki-sato opened a new pull request, #47290:
URL: https://github.com/apache/arrow/pull/47290
### Rationale for this change
* SC1090: Can't follow non-constant source. Use a directive to specify
location
* SC2086: Double quote to prevent globbing and word splitting
```
In ci/scripts/python_build_emscripten.sh line 26:
source ~/emsdk/emsdk_env.sh
^------------------^ SC1090 (warning): ShellCheck can't follow
non-constant source. Use a directive to specify location.
In ci/scripts/python_build_emscripten.sh line 31:
rm -rf ${python_build_dir}
^-----------------^ SC2086 (info): Double quote to prevent globbing
and word splitting.
Did you mean:
rm -rf "${python_build_dir}"
In ci/scripts/python_build_emscripten.sh line 32:
cp -aL ${source_dir} ${python_build_dir}
^-----------^ SC2086 (info): Double quote to prevent globbing and
word splitting.
^-----------------^ SC2086 (info): Double quote to
prevent globbing and word splitting.
Did you mean:
cp -aL "${source_dir}" "${python_build_dir}"
In ci/scripts/python_build_emscripten.sh line 38:
pushd ${python_build_dir}
^-----------------^ SC2086 (info): Double quote to prevent globbing
and word splitting.
Did you mean:
pushd "${python_build_dir}"
For more information:
https://www.shellcheck.net/wiki/SC1090 -- ShellCheck can't follow
non-const...
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing
...
```
### What changes are included in this PR?
* SC1090: disable source file check.
* SC2086: Quote variables.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
