amoeba commented on code in PR #3251:
URL: https://github.com/apache/arrow-adbc/pull/3251#discussion_r2264767177
##########
c/driver_manager/adbc_driver_manager_test.cc:
##########
@@ -417,7 +417,9 @@ class DriverManifest : public ::testing::Test {
auto temp_path = std::filesystem::temp_directory_path();
temp_path /= "adbc_driver_manager_test";
- ASSERT_TRUE(std::filesystem::create_directories(temp_path));
+ if (!std::filesystem::exists(temp_path)) {
+ ASSERT_TRUE(std::filesystem::create_directories(temp_path));
Review Comment:
I'm not sure we gain anything though I kinda like failing the test here. It
certainly helped me figure out where to start looking (versus an actual test
body failing).
I went ahead and minimized the code in follow-up commits. Is that about what
you were thinking?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
