kou commented on code in PR #47313:
URL: https://github.com/apache/arrow/pull/47313#discussion_r2271429226
##########
ci/docker/linux-apt-python-313-freethreading.dockerfile:
##########
@@ -32,13 +32,18 @@ COPY python/requirements-build.txt \
ENV ARROW_PYTHON_VENV /arrow-dev
RUN python3.13t -m venv ${ARROW_PYTHON_VENV}
+
+# Free-threaded CPython 3.13 needs pinned cffi version
+RUN sed '/^cffi/d' /arrow/python/requirements-test.txt >
/arrow/python/requirements-patched.txt && \
+ echo "cffi<2.0.0" >> /arrow/python/requirements-patched.txt
Review Comment:
Can we use Environment Markers
https://packaging.python.org/en/latest/specifications/dependency-specifiers/#environment-markers
instead of this approach? Something like:
```diff
--- a/python/requirements-test.txt
+++ b/python/requirements-test.txt
@@ -1,4 +1,5 @@
-cffi
+cffi; python_version != '3.13t'
+cffi<2.0.0; python_version == '3.13t'
hypothesis
packaging
pandas
```
(I'm not sure whether we have a variable to determine free-threaded
CPython...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]