scovich commented on code in PR #8135:
URL: https://github.com/apache/arrow-rs/pull/8135#discussion_r2276910471
##########
parquet-variant/src/variant.rs:
##########
@@ -1286,6 +1286,59 @@ impl TryFrom<(i128, u8)> for Variant<'_, '_> {
}
}
+impl std::fmt::Debug for Variant<'_, '_> {
+ fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+ match self {
+ Variant::Null => write!(f, "null"),
Review Comment:
I pulled out the impl Debug as its own PR that should merge first:
* https://github.com/apache/arrow-rs/pull/8140
Let's pick up the conversation there as needed, this PR will shrink a lot
after rebasing on top of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
