pitrou commented on code in PR #47297:
URL: https://github.com/apache/arrow/pull/47297#discussion_r2284715164
##########
cpp/src/arrow/compute/kernel.cc:
##########
@@ -475,23 +475,78 @@ std::string OutputType::ToString() const {
return "computed";
}
+// ----------------------------------------------------------------------
+// MatchConstraint
+
+std::shared_ptr<MatchConstraint> DecimalsHaveSameScale() {
+ class DecimalsHaveSameScaleConstraint : public MatchConstraint {
+ public:
+ bool Validate(const std::vector<TypeHolder>& types) const override {
+ DCHECK_GE(types.size(), 2);
+ DCHECK(std::all_of(types.begin(), types.end(),
+ [](const TypeHolder& type) { return
is_decimal(type.id()); }));
+ auto ty0 = dynamic_cast<const DecimalType*>(types[0].type);
+ DCHECK_NE(ty0, nullptr);
+ auto s0 = ty0->scale();
+ for (size_t i = 1; i < types.size(); ++i) {
+ auto ty = dynamic_cast<const DecimalType*>(types[i].type);
+ DCHECK_NE(ty, nullptr);
+ if (ty->scale() != s0) {
+ return false;
+ }
+ }
+ return true;
+ }
+ };
+ static auto instance = std::make_shared<DecimalsHaveSameScaleConstraint>();
Review Comment:
Hmm, did someone decide to add Copilot reviews to the Arrow repo, or is that
up to each PR author?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
