scovich commented on code in PR #8172:
URL: https://github.com/apache/arrow-rs/pull/8172#discussion_r2286705495


##########
parquet-variant/src/builder.rs:
##########
@@ -589,6 +588,7 @@ impl<S: AsRef<str>> Extend<S> for MetadataBuilder {
 /// parent, and we cannot "split" a mutable reference across two objects 
(parent state and the child
 /// builder that uses it). So everything has to be here. Rust layout 
optimizations should treat the
 /// variants as a union, so that accessing a `buffer` or `metadata_builder` is 
branch-free.
+#[derive(Debug)]

Review Comment:
   Needed when invoking `unwrap_err` on a `Result<ObjectBuilder>` (unit test)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to