carpecodeum commented on code in PR #8166:
URL: https://github.com/apache/arrow-rs/pull/8166#discussion_r2291735851
##########
parquet-variant/src/path.rs:
##########
@@ -95,10 +95,19 @@ impl<'a> From<Vec<VariantPathElement<'a>>> for
VariantPath<'a> {
}
}
-/// Create from &str
+/// Create from &str with support for dot notation
impl<'a> From<&'a str> for VariantPath<'a> {
fn from(path: &'a str) -> Self {
- VariantPath::new(vec![path.into()])
+ // Support dot notation: "a.x" -> ["a", "x"]
+ if path.contains('.') {
Review Comment:
I agree with the long-form more, but I just added this just as a proof of
concept, to see what opinion everyone has of this, can fallback to the original
approach, maybe @alamb can also give his opinion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
