lidavidm commented on code in PR #47410:
URL: https://github.com/apache/arrow/pull/47410#discussion_r2296515008
##########
cpp/src/arrow/flight/transport_server.cc:
##########
@@ -188,71 +227,55 @@ class TransportMessageWriter final : public
FlightMessageWriter {
Status WriteMetadata(std::shared_ptr<Buffer> app_metadata) override {
FlightPayload payload{};
payload.app_metadata = app_metadata;
- return WritePayload(payload);
+ ARROW_ASSIGN_OR_RAISE(auto success, stream_->WriteData(payload));
+ if (!success) {
+ return Close();
+ }
+ // Those messages are not written through the batch writer,
+ // count them separately for stats.
+ extra_metadata_messages_++;
Review Comment:
I'm not sure they should count as "metadata" in the first place (aren't the
stats for IPC metadata?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
