kou commented on code in PR #47408: URL: https://github.com/apache/arrow/pull/47408#discussion_r2297145598
########## cpp/cmake_modules/ThirdpartyToolchain.cmake: ########## @@ -1024,6 +1024,14 @@ macro(prepare_fetchcontent) # We should remove it once we have updated the dependencies: # https://github.com/apache/arrow/issues/45985 set(CMAKE_POLICY_VERSION_MINIMUM 3.5) + # Use "NEW" for CMP0077 by default. + # + # https://cmake.org/cmake/help/latest/policy/CMP0077.html + # + # option() honors normal variables. + set(CMAKE_POLICY_DEFAULT_CMP0077 Review Comment: Right. ########## cpp/cmake_modules/ThirdpartyToolchain.cmake: ########## @@ -4599,8 +4607,26 @@ target_include_directories(arrow::hadoop INTERFACE "${HADOOP_HOME}/include") # Apache ORC function(build_orc) + list(APPEND CMAKE_MESSAGE_INDENT "Apache ORC: ") + message(STATUS "Building Apache ORC from source") + set(ORC_PATCHES) + if(MSVC) + # We can remove this once bundled Apache ORC is 2.2.1 or later. + list(APPEND ORC_PATCHES ${CMAKE_CURRENT_LIST_DIR}/orc-2345.patch) + endif() + if(Protobuf_VERSION VERSION_GREATER_EQUAL 32.0) + # We can remove this once bundled Apache ORC is 2.2.1 or later. + list(APPEND ORC_PATCHES ${CMAKE_CURRENT_LIST_DIR}/orc-2357.patch) + endif() + if(ORC_PATCHES) + find_program(PATCH patch REQUIRED) Review Comment: Based on the CI result, we don't need to add additional patch dependency. But let's try R and wheel related CI jobs before we merge this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
