ianmcook commented on code in PR #3320:
URL: https://github.com/apache/arrow-adbc/pull/3320#discussion_r2298823073
##########
c/driver_manager/adbc_driver_manager.cc:
##########
@@ -446,14 +489,22 @@ struct ManagedLibrary {
return ADBC_STATUS_NOT_FOUND;
}
- AdbcStatusCode FindDriver(const std::filesystem::path& driver_path,
- const AdbcLoadFlags load_options, DriverInfo& info,
- struct AdbcError* error) {
+ AdbcStatusCode FindDriver(
+ const std::filesystem::path& driver_path, const AdbcLoadFlags
load_options,
+ const std::vector<std::filesystem::path>& additional_search_paths,
DriverInfo& info,
+ struct AdbcError* error) {
if (driver_path.empty()) {
SetError(error, "Driver path is empty");
return ADBC_STATUS_INVALID_ARGUMENT;
}
+ {
+ auto status = SearchPaths(driver_path, additional_search_paths, info,
error);
+ if (status == ADBC_STATUS_OK) {
+ return status;
+ }
+ }
+
Review Comment:
Easy but hacky way to do it: If user adds additional search paths AND
`LOAD_FLAG_SEARCH_ENV` flag is set, then add `$ADBC_CONFIG_PATH` to the
beginning of the user-added search paths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
