raulcd commented on issue #47440:
URL: https://github.com/apache/arrow/issues/47440#issuecomment-3228254957

   I am not sure why our `FindgflagsAlt.cmake` seems to miss the 
`GFLAGS_IS_A_DLL` flag from the new commit, it seems it's correctly defined 
upstream:
   ```cmake
   if(BUILD_SHARED_LIBS)
     set (type_suffix "_shared")
     set (LIB_TYPE SHARED)
     set (GFLAGS_IS_A_DLL 1)
   else()
     set (type_suffix "_static")
     set (LIB_TYPE STATIC)
     set (GFLAGS_IS_A_DLL 0)
   endif()
   ```
   and
   ```cmake
   # Compile Definitions (Modified with proper GFLAGS_IS_A_DLL handling)
   target_compile_definitions(gflags PUBLIC GFLAGS_IS_A_DLL=${GFLAGS_IS_A_DLL})
   ```
   cc @kou 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to