pitrou commented on code in PR #47432:
URL: https://github.com/apache/arrow/pull/47432#discussion_r2307185797
##########
python/pyarrow/tests/test_flight.py:
##########
@@ -2128,6 +2152,7 @@ def test_doexchange_echo():
chunk = reader.read_chunk()
assert chunk.data == batch
assert chunk.app_metadata == buf
+ assert reader.stats.num_record_batches == num_batches + i + 1
Review Comment:
For clarity, how about `num_batches += 1` as above?
##########
python/pyarrow/tests/test_flight.py:
##########
@@ -2090,6 +2109,8 @@ def test_doexchange_put():
assert chunk.data is None
expected_buf = str(len(batches)).encode("utf-8")
assert chunk.app_metadata == expected_buf
+ # Metadata only message is not counted as an ipc data message
+ assert reader.stats.num_messages == 0
Review Comment:
But they are on the write side, do we mind the discrepancy?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
