wgtmac commented on PR #46906:
URL: https://github.com/apache/arrow/pull/46906#issuecomment-3239017658
That's weird. The `GetFieldMetadata` function does not call
`orc::TypeImpl::getTypeByColumnId` internally. Even the ORC library does not
call it internally.
```
Result<std::shared_ptr<const KeyValueMetadata>> GetFieldMetadata(
const liborc::Type* type) {
if (type == nullptr) {
return nullptr;
}
const auto keys = type->getAttributeKeys();
if (keys.empty()) {
return nullptr;
}
auto metadata = std::make_shared<KeyValueMetadata>();
for (const auto& key : keys) {
metadata->Append(key, type->getAttributeValue(key));
}
return std::const_pointer_cast<const KeyValueMetadata>(metadata);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
