gobes commented on issue #47229:
URL: https://github.com/apache/arrow/issues/47229#issuecomment-3240587130
@pitrou, no, it does not fix the issue.
Try 1, via arrow cmake -DMIMALLOC_CMAKE_ARGS="-DMI_NO_OPT_ARCH=ON" \
result : still crash on the same line
Try 2, hard-coded in python/cmake_modules/ThirdpartyToolchain.cmake
> set(MIMALLOC_CMAKE_ARGS
${EP_COMMON_CMAKE_ARGS}
"-DCMAKE_C_FLAGS=${MIMALLOC_C_FLAGS}"
"-DCMAKE_INSTALL_PREFIX=${MIMALLOC_PREFIX}"
-DMI_OVERRIDE=OFF
-DMI_LOCAL_DYNAMIC_TLS=ON
-DMI_BUILD_OBJECT=OFF
-DMI_BUILD_SHARED=OFF
-DMI_NO_OPT_ARCH=ON <---------------
-DMI_BUILD_TESTS=OFF)
result: still crash on the same line
Try 3, just disable it -DARROW_MIMALLOC=OFF
result: **pass** (probably the quicker temporary fix for these cpu; Is there
any equivalent run time env. to disable it ? )
Both tries by cross-compile and native.
-DMI_NO_OPT_ARCH it may not be propagated correctly on try 1/2, but even if
it does, I'm not sure it will fix it.
Arrow 21.0.0 seems to use ARROW_MIMALLOC_BUILD_VERSION=v2.2.4.
A quick look into
https://github.com/microsoft/mimalloc/blob/09a27098aa6e9286518bd9c74e6ffa7199c3f04e/CMakeLists.txt#L146),
MI_NO_OPT_ARCH=ON doesn't do too much, it just prevent -march=armv8.1-a to be
passed to compiler, so the -march will be "armv8-a".
But -march=armv8-a, it was not enough for cortex-a72/a57, that's why I ended
up in adding -mtune=cortex-a72 -mno-outline-atomics
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
