ryan-syed commented on code in PR #3380:
URL: https://github.com/apache/arrow-adbc/pull/3380#discussion_r2317368559
##########
csharp/src/Drivers/Apache/Spark/SparkStandardConnection.cs:
##########
@@ -95,19 +99,69 @@ protected override TTransport CreateTransport()
// Assumption: hostName and port have already been validated.
Properties.TryGetValue(SparkParameters.HostName, out string?
hostName);
Properties.TryGetValue(SparkParameters.Port, out string? port);
+ Properties.TryGetValue(SparkParameters.AuthType, out string?
authType);
Review Comment:
There was a bug in the validation logic, where in case of a unspecified port
number, the null port was being parsed as a integer value of zero and not
throwing an exception. Added validation logic for missing port number in
SparkStandardConnection.
The same needs to be handled in SparkHttpConnection and for Hive, and Impala
too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
