HuaHuaY commented on code in PR #47090:
URL: https://github.com/apache/arrow/pull/47090#discussion_r2313251253
##########
cpp/src/parquet/column_writer_test.cc:
##########
@@ -506,6 +509,44 @@ void
TestPrimitiveWriter<FLBAType>::ReadColumnFully(Compression::type compressio
this->SyncValuesOut();
}
+template <>
+void TestPrimitiveWriter<ByteArrayType>::ReadColumnFully(Compression::type
compression,
+ bool
page_checksum_verify) {
+ int64_t total_values = static_cast<int64_t>(this->values_out_.size());
+ BuildReader(total_values, compression, page_checksum_verify);
+ this->data_buffer_.clear();
+
+ values_read_ = 0;
+ while (values_read_ < total_values) {
+ int64_t values_read_recently = 0;
+ reader_->ReadBatch(
+ static_cast<int>(this->values_out_.size()) -
static_cast<int>(values_read_),
+ definition_levels_out_.data() + values_read_,
+ repetition_levels_out_.data() + values_read_,
+ this->values_out_ptr_ + values_read_, &values_read_recently);
Review Comment:
```suggestion
reader_->ReadBatch(total_values - values_read_,
definition_levels_out_.data() + values_read_,
repetition_levels_out_.data() + values_read_,
this->values_out_ptr_ + values_read_,
&values_read_recently);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
