zanmato1984 commented on code in PR #47479:
URL: https://github.com/apache/arrow/pull/47479#discussion_r2317553639
##########
cpp/src/arrow/compute/kernel.h:
##########
@@ -356,11 +356,11 @@ class ARROW_EXPORT MatchConstraint {
/// \brief Return true if the input types satisfy the constraint.
virtual bool Matches(const std::vector<TypeHolder>& types) const = 0;
-};
-/// \brief Convenience function to create a MatchConstraint from a match
function.
-ARROW_EXPORT std::shared_ptr<MatchConstraint> MakeConstraint(
- std::function<bool(const std::vector<TypeHolder>&)> matches);
+ /// \brief Convenience function to create a MatchConstraint from a match
function.
+ static std::shared_ptr<MatchConstraint> Make(
Review Comment:
Not really related to the issue. Just a small refinement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
