amoeba commented on code in PR #3388:
URL: https://github.com/apache/arrow-adbc/pull/3388#discussion_r2320477872
##########
docs/source/rust/driver_manager.rst:
##########
@@ -20,34 +20,35 @@ Driver Manager
==============
This document describes the installation and usage of the Rust :term:`driver
-manager`. The Rust :term:`driver manager` is currently part of the
``adbc_core``
-package, though we plan to split it into its own package for to keep the
-``adbc_core`` package smaller for users who don't want or need FFI.
+manager` which is available in the ``adbc_driver_manager`` crate.
Installation
============
.. code-block:: shell
- cargo add adbc_core --features driver_manager
+ cargo add adbc_core adbc_driver_manager
Usage
=====
.. code-block:: rust
- use adbc_core::{Connection, Database, Driver, Statement};
- use adbc_core::options::{AdbcVersion, OptionDatabase};
- use adbc_core::driver_manager::ManagedDriver;
+ use adbc_core::options::AdbcVersion;
+ use adbc_core::{Database, Driver};
+ use adbc_driver_manager::ManagedDriver;
// You must build/locate the driver yourself
let mut driver = ManagedDriver::load_dynamic_from_filename(
"/PATH/TO/libadbc_driver_sqlite.so",
None,
AdbcVersion::default(),
- ).expect("Failed to load driver");
- let db = driver.new_database().expect("Failed to create database handle");
- let mut conn = db.new_connection().expect("Failed to create connection");
+ )
+ .expect("Failed to load driver");
Review Comment:
It is "right", strangely enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
