alamb commented on code in PR #8233:
URL: https://github.com/apache/arrow-rs/pull/8233#discussion_r2326099368
##########
parquet-variant-compute/src/cast_to_variant.rs:
##########
@@ -46,72 +46,99 @@ use parquet_variant::{
Variant, VariantBuilder, VariantDecimal16, VariantDecimal4,
VariantDecimal8,
};
-fn convert_timestamp(
+/// Options for controlling the behavior of `cast_to_variant_with_options`.
+#[derive(Debug, Clone, PartialEq, Eq)]
+pub struct CastOptions {
Review Comment:
This looks quite similar to
https://docs.rs/arrow/latest/arrow/compute/struct.CastOptions.html
However that seems to be defined in arrow-compute
https://github.com/apache/arrow-rs/blob/0ba91aed9c03ae5fd40db668e51fa138421b38b1/parquet-variant-compute/Cargo.toml#L33
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
