kou commented on code in PR #47164:
URL: https://github.com/apache/arrow/pull/47164#discussion_r2321463630
##########
cpp/src/arrow/table_test.cc:
##########
@@ -152,38 +153,234 @@ TEST_F(TestTable, AllColumnsAndFields) {
ASSERT_EQ(0, fields.size());
}
-TEST_F(TestTable, Equals) {
- const int length = 100;
- MakeExample1(length);
+class TestTableEquality : public TestTable {};
- table_ = Table::Make(schema_, columns_);
+TEST_F(TestTableEquality, Equals) {
Review Comment:
Yes. The last typo point is interesting but `TEST_F()` is overkill for it.
If we use `TEST_F()` without fixture, it just confuses us.
Let's use simpler `TEST()` for this. In general, simpler code is more
readable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
