pitrou commented on code in PR #47294:
URL: https://github.com/apache/arrow/pull/47294#discussion_r2322142141
##########
cpp/src/arrow/util/rle_encoding_test.cc:
##########
@@ -553,47 +853,178 @@ TEST(BitRle, Overflow) {
}
}
-template <typename Type>
-void CheckRoundTripSpaced(const Array& data, int bit_width) {
+/// Check RleBitPacked encoding/decoding round trip.
+///
+/// \tparam kSpaced If set to false, treat Nulls in the input array as regular
data.
+/// \tparam kParts The number of parts in which the data will be decoded.
+/// For number greater than one, this ensure that the decoder
intermediary state
+/// is valid.
+template <typename Type, bool kSpaced, int32_t kParts>
Review Comment:
Why pass `kSpaced` and `kParts` as template parameters? We should try to
minimize compile times in tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
