scovich commented on PR #8299: URL: https://github.com/apache/arrow-rs/pull/8299#issuecomment-3272149499
Attn @codephage2020 -- this PR conflicts with * https://github.com/apache/arrow-rs/pull/8233 Most of the code that other PR touched has been deleted by this PR, so I did my best to capture the intent in the new framework. While resolving conflicts, I also had to expand the `define_row_builder!` macro to handle fallible conversions, which increased its complexity a bit. Hopefully still readable. The merge commit https://github.com/apache/arrow-rs/pull/8299/commits/26ae5c07a3f48ce00ebc793cfd8b6326fb459bfb actually makes it pretty easy to see what changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
