WillAyd commented on code in PR #47282:
URL: https://github.com/apache/arrow/pull/47282#discussion_r2335177775
##########
cpp/src/arrow/meson.build:
##########
@@ -420,19 +481,38 @@ foreach key, val : arrow_components
arrow_deps += val.get('dependencies', [])
endforeach
+arrow_lib_cpp_shared_args = ['-DARROW_EXPORTING', '-DURI_LIBRARY_BUILD']
+if needs_compute
+ arrow_lib_cpp_shared_args += ['-DARROW_COMPUTE_EXPORTING']
+endif
+
arrow_lib = library(
'arrow',
sources: arrow_srcs,
include_directories: arrow_includes,
dependencies: arrow_deps,
install: true,
gnu_symbol_visibility: 'inlineshidden',
- cpp_shared_args: ['-DARROW_EXPORTING'],
+ gnu_symbol_visibility: 'hidden',
+ c_shared_args: [
+ '-DARROW_EXPORTING',
+ '-DURI_LIBRARY_BUILD',
+ '-DURI_VISIBILITY',
Review Comment:
It does not - that macro is used by the vendored/uriparser code which is
built via the C compiler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
