lidavidm commented on code in PR #837:
URL: https://github.com/apache/arrow-java/pull/837#discussion_r2335956636
##########
vector/src/main/java/org/apache/arrow/vector/BaseValueVector.java:
##########
@@ -260,6 +261,18 @@ public void copyFromSafe(int fromIndex, int thisIndex,
ValueVector from) {
throw new UnsupportedOperationException();
}
+ @Override
+ public void copyFrom(
+ int fromIndex, int thisIndex, ValueVector from,
ExtensionTypeWriterFactory writerFactory) {
+ throw new UnsupportedOperationException();
Review Comment:
Should these be abstract methods instead?
##########
vector/src/main/codegen/templates/ComplexCopier.java:
##########
@@ -110,6 +114,21 @@ private static void writeValue(FieldReader reader,
FieldWriter writer) {
writer.writeNull();
}
break;
+ case EXTENSIONTYPE:
+ if (extensionTypeWriterFactory == null) {
+ throw new UnsupportedOperationException(
+ "EXTENSIONTYPE are not supported yet. Please provide an
ExtensionTypeWriterFactory." );
Review Comment:
I don't think we can ever support extension without the factory right?
```suggestion
throw new IllegalArgumentException(
"Must provide ExtensionTypeWriterFactory" );
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
