gitmodimo commented on PR #47386:
URL: https://github.com/apache/arrow/pull/47386#issuecomment-3273957516

   > Would it be possible to write a case about it?
   
   I added as UT. It would be difficult to orchestrate using ExecNodes.
   
   This test fails against current main.
   ```
   TEST(BackpressureConcurrentQueue, BackpressureTestStayUnpaused) {
     BackpressureTestExecNode dummy_node;
     auto ctrl = std::make_unique<TestBackpressureControl>(&dummy_node);
     ASSERT_OK_AND_ASSIGN(auto handler,
                          BackpressureHandler::Make(&dummy_node, 2, 4, 
std::move(ctrl)));
     BackpressureConcurrentQueue<int> queue(std::move(handler));
   
     queue.Push(6);
     queue.Push(7);
     queue.Push(8);
     ASSERT_FALSE(dummy_node.paused);
     ASSERT_FALSE(dummy_node.stopped);
     ASSERT_OK(queue.ForceShutdown());
     for(int i=0;i<10;++i){    
       queue.Push(i);
     }
     ASSERT_FALSE(dummy_node.paused); // fails
     ASSERT_TRUE(dummy_node.stopped);
   }
   ```
   
   Anyways I hope ForceShutdown will become obsolete after acero refactor 
succeeds .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to