etseidl commented on code in PR #8237:
URL: https://github.com/apache/arrow-rs/pull/8237#discussion_r2337659751
##########
parquet/src/basic.rs:
##########
@@ -646,6 +774,39 @@ impl<'a> TryFrom<&mut ThriftCompactInputProtocol<'a>> for
Compression {
}
}
+// FIXME
Review Comment:
I'll remove. This is one of those situations where I have to hand-do the
serialization code. I could instead use a private intermediate struct and then
translate...it's just an enum after all.
another example is `LogicalType`. The current implementation uses struct
variants, but the thrift macros use tuple variants. I could remove a lot of
code if we just change that, but there would be ripples.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
