kou commented on code in PR #47546:
URL: https://github.com/apache/arrow/pull/47546#discussion_r2337866998
##########
.github/workflows/cpp_extra.yml:
##########
@@ -278,3 +278,36 @@ jobs:
cmake --build cpp/examples/minimal_build.build
cd cpp/examples/minimal_build
../minimal_build.build/arrow-example
+
+ report-extra-cpp:
+ runs-on: ubuntu-latest
+ needs:
+ - docker
+ - jni-macos
+ # We don't have the job id as part of the context neither the job name.
+ # The GitHub API exposes numeric id or job name but not the github.job
(report-extra-cpp).
+ # We match github.job to the name so we can pass it via context in order
to be ignored on the report.
+ # The job is still running.
+ name: ${{ github.job }}
+ if: always()
+ steps:
+ - name: Checkout Arrow
+ uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 #
v5.0.0
+ with:
+ fetch-depth: 0
+ - name: Setup Python
+ uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c #
v6.0.0
+ with:
+ python-version: 3
+ - name: Setup Archery
+ run: python3 -m pip install -e dev/archery[crossbow]
+ - name: Notify
+ env:
+ GH_TOKEN: ${{ github.token }}
+ run: |
+ archery arrowci report-chat \
Review Comment:
How about `ci` instead of `arrowci` because Archery is a tool for Arrow?
```suggestion
archery ci report-chat \
```
##########
.github/workflows/cpp_extra.yml:
##########
@@ -278,3 +278,36 @@ jobs:
cmake --build cpp/examples/minimal_build.build
cd cpp/examples/minimal_build
../minimal_build.build/arrow-example
+
+ report-extra-cpp:
+ runs-on: ubuntu-latest
+ needs:
+ - docker
+ - jni-macos
+ # We don't have the job id as part of the context neither the job name.
+ # The GitHub API exposes numeric id or job name but not the github.job
(report-extra-cpp).
+ # We match github.job to the name so we can pass it via context in order
to be ignored on the report.
+ # The job is still running.
+ name: ${{ github.job }}
+ if: always()
+ steps:
+ - name: Checkout Arrow
+ uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 #
v5.0.0
+ with:
+ fetch-depth: 0
+ - name: Setup Python
+ uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c #
v6.0.0
+ with:
+ python-version: 3
+ - name: Setup Archery
+ run: python3 -m pip install -e dev/archery[crossbow]
+ - name: Notify
+ env:
+ GH_TOKEN: ${{ github.token }}
+ run: |
+ archery arrowci report-chat \
+ --ignore ${{ github.job }} \
+ --repository ${{ github.repository }} \
+ --dry-run \
+ --webhook ${{ secrets.ARROW_ZULIP_WEBHOOK }} \
Review Comment:
How about passing this via environment variable like `--github-token`?
`${{ secrets.ARROW_ZULIP_WEBHOOK }}` is empty on pull request and push on
fork.
##########
.github/workflows/cpp_extra.yml:
##########
@@ -278,3 +278,36 @@ jobs:
cmake --build cpp/examples/minimal_build.build
cd cpp/examples/minimal_build
../minimal_build.build/arrow-example
+
+ report-extra-cpp:
+ runs-on: ubuntu-latest
+ needs:
+ - docker
+ - jni-macos
+ # We don't have the job id as part of the context neither the job name.
+ # The GitHub API exposes numeric id or job name but not the github.job
(report-extra-cpp).
+ # We match github.job to the name so we can pass it via context in order
to be ignored on the report.
+ # The job is still running.
+ name: ${{ github.job }}
+ if: always()
Review Comment:
How about using `github.repository == 'apache/arrow' && github.event_name ==
'push'` instead of `always()`?
We don't need to report on fork and pull request.
##########
dev/archery/archery/templates/chat_nightly_report_workflow.txt.j2:
##########
@@ -0,0 +1,38 @@
+{#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#}
+*<Extra CI GitHub report> for <{{ report.workflow.url }}|{{
report.workflow.name }}>*
Review Comment:
It's for Zulip, right?
Zulip uses Markdown:
https://zulip.com/help/format-your-message-using-markdown
```suggestion
*Extra CI GitHub report for [{{ report.workflow.url }}]({{
report.workflow.name }})*
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
