CurtHagenlocher commented on code in PR #3397:
URL: https://github.com/apache/arrow-adbc/pull/3397#discussion_r2341902042
##########
csharp/src/Telemetry/Traces/Exporters/FileExporter/FileExporter.cs:
##########
@@ -203,13 +203,13 @@ private FileExporter(string fileBaseName, DirectoryInfo
tracesDirectory, long ma
ApacheArrowAdbcNamespace,
TracesFolderName)).FullName;
- private async Task FlushAsync(CancellationToken cancellationToken =
default)
+ private void FlushAsync(CancellationToken cancellationToken = default)
{
// Ensure existing writes are completed.
- _ = _channel.Writer.TryComplete();
+ _channel.Writer.TryComplete();
while (!cancellationToken.IsCancellationRequested &&
!_isProcessingComplete)
{
- await Task.Delay(100);
+ Thread.Sleep(100);
Review Comment:
Oh, I see this is called from the synchronous `Dispose` method. If we could
target only modern .NET then we could use `DisposeAsync` instead of `Dispose`.
Given that this is now synchronous, it probably shouldn't be named `Async`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
