Erigara commented on code in PR #8266:
URL: https://github.com/apache/arrow-rs/pull/8266#discussion_r2332455589
##########
parquet/src/record/api.rs:
##########
@@ -928,29 +928,22 @@ fn convert_date_to_string(value: i32) -> String {
format!("{}", dt.format("%Y-%m-%d"))
}
-/// Helper method to convert Parquet timestamp into a string.
-/// Input `value` is a number of seconds since the epoch in UTC.
-/// Datetime is displayed in local timezone.
-#[inline]
-fn convert_timestamp_secs_to_string(value: i64) -> String {
- let dt = Utc.timestamp_opt(value, 0).unwrap();
- format!("{}", dt.format("%Y-%m-%d %H:%M:%S %:z"))
-}
-
/// Helper method to convert Parquet timestamp into a string.
/// Input `value` is a number of milliseconds since the epoch in UTC.
/// Datetime is displayed in local timezone.
#[inline]
fn convert_timestamp_millis_to_string(value: i64) -> String {
- convert_timestamp_secs_to_string(value / 1000)
+ let dt = Utc.timestamp_millis_opt(value).unwrap();
+ format!("{}", dt.format("%Y-%m-%d %H:%M:%S%.3f %:z"))
Review Comment:
I've updated doc to reflect that timestamps are returned in UTC timezone.
`%:z` timestamp is still in place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
