WillAyd commented on code in PR #47556:
URL: https://github.com/apache/arrow/pull/47556#discussion_r2345322880
##########
cpp/src/arrow/util/visibility.h:
##########
@@ -67,6 +67,11 @@
# ifndef ARROW_NO_EXPORT
# define ARROW_NO_EXPORT [[gnu::visibility("hidden")]]
# endif
+# if defined(__clang__)
Review Comment:
This part of the language appears to be vague, and gcc / clang have
differing behavior. See https://github.com/llvm/llvm-project/issues/29464 and
https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2017/p0537r0.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
