alamb commented on code in PR #8315:
URL: https://github.com/apache/arrow-rs/pull/8315#discussion_r2341541129
##########
parquet/src/arrow/arrow_reader/filter.rs:
##########
@@ -172,7 +172,7 @@ where
/// [`RowSelection`]: crate::arrow::arrow_reader::RowSelection
pub struct RowFilter {
/// A list of [`ArrowPredicate`]
- pub(crate) predicates: Vec<Box<dyn ArrowPredicate>>,
+ pub predicates: Vec<Box<dyn ArrowPredicate>>,
Review Comment:
Instead of making this pub, can you please make an accessor so we can change
the internals of RowFilter without causing a breaking API change?
Perhaps something like
```rust
impl RowFilter {
pub fn predicate(&self) -> &Vec<Box<dyn ArrowPredicate>> { .. }
// and convert into the innner
pub fn into_predicates(self) -> Vec<Box<dyn ArrowPredicate>> { .. }
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
