pitrou commented on code in PR #47515:
URL: https://github.com/apache/arrow/pull/47515#discussion_r2349156098
##########
cpp/src/arrow/util/bpacking_avx2.cc:
##########
@@ -19,13 +19,11 @@
#include "arrow/util/bpacking_simd256_generated_internal.h"
#include "arrow/util/bpacking_simd_internal.h"
-namespace arrow {
-namespace internal {
+namespace arrow::internal {
-int unpack32_avx2(const uint32_t* in, uint32_t* out, int batch_size, int
num_bits) {
- return unpack32_specialized<UnpackBits256<DispatchLevel::AVX2>>(in, out,
batch_size,
- num_bits);
+int unpack32_avx2(const uint8_t* in, uint32_t* out, int batch_size, int
num_bits) {
+ return unpack32_specialized<UnpackBits256<DispatchLevel::AVX2>>(
+ reinterpret_cast<const uint32_t*>(in), out, batch_size, num_bits);
Review Comment:
Fair enough!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
