WillAyd commented on code in PR #47568:
URL: https://github.com/apache/arrow/pull/47568#discussion_r2349902771
##########
cpp/src/arrow/meson.build:
##########
@@ -408,7 +408,52 @@ if needs_filesystem
endif
if needs_gcs
- error('gcs filesystem support is not yet implemented in Meson')
+ arrow_filesystem_srcs += files(
+ 'filesystem/gcsfs.cc',
+ 'filesystem/gcsfs_internal.cc',
+ )
+
+ gcs_common_dep = dependency(
+ 'google_cloud_cpp_common',
+ allow_fallback: false,
+ required: false,
+ )
+ gcs_rest_internal_dep = dependency(
+ 'google_cloud_cpp_rest_internal',
+ allow_fallback: false,
+ required: false,
+ )
+ gcs_storage_dep = dependency(
+ 'google_cloud_cpp_storage',
+ allow_fallback: false,
+ required: false,
+ )
+
+ if not (gcs_common_dep.found()
Review Comment:
This is some unfortunate indentation - opened an upstream issue at
https://github.com/mesonbuild/meson/issues/15032
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
