zeroshade commented on code in PR #3428:
URL: https://github.com/apache/arrow-adbc/pull/3428#discussion_r2353720178
##########
c/driver_manager/adbc_driver_manager.cc:
##########
@@ -720,7 +720,7 @@ struct ManagedLibrary {
search_paths.emplace_back(SearchPathSource::kAdditional, path);
}
-#if ADBC_CONDA_BUILD
+#if defined(ADBC_CONDA_BUILD)
Review Comment:
So, this was set up this way because of the R build which uses
`-DADBC_CONDA_BUILD=${CONDA_BUILD}` because of how `Makevars` in R doesn't
allow a bunch of different Make constructs.
So changing this like this will result in this being built for the R driver
manager even when not using CONDA_BUILD
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
