scovich commented on code in PR #8357:
URL: https://github.com/apache/arrow-rs/pull/8357#discussion_r2354152655
##########
parquet-variant/src/variant.rs:
##########
@@ -1096,13 +1096,21 @@ impl<'m, 'v> Variant<'m, 'v> {
/// let v2 = Variant::from(std::f64::consts::PI);
/// assert_eq!(v2.as_f16(), Some(f16::from_f64(std::f64::consts::PI)));
///
+ /// // and from integers with no more than 11 bits of precision
Review Comment:
The unit test for `fits_precision` does test overflow, both positive and
negative.
Do we need additional (indirect) test coverage here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
