rok commented on issue #47520: URL: https://github.com/apache/arrow/issues/47520#issuecomment-3298806902
@andishgar your patch looks good but it does cover a lot of ground. It would be nice to have wrong-index-when-positive/negative-zero, column-major and half-float features as separate PRs. Perhaps you could start with opening a PR for this issue adding just `is_not_zero` utility (without float16) so we can land it before the release? It seems like it should be a small change. For the rest of the diff perhaps first make an issue for the column-major index feature and use the full patch. Float16 would also be nice in a separate patch, but it'll probably be easier to split out than the column-major part. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
