scovich commented on code in PR #8360:
URL: https://github.com/apache/arrow-rs/pull/8360#discussion_r2354370265
##########
parquet-variant/src/variant.rs:
##########
@@ -1323,7 +1323,7 @@ impl<'m, 'v> Variant<'m, 'v> {
/// Return the metadata associated with this variant, if any.
///
/// Returns `Some(&VariantMetadata)` for object and list variants,
- pub fn metadata(&self) -> Option<&'m VariantMetadata<'_>> {
+ pub fn metadata(&self) -> Option<&VariantMetadata<'m>> {
Review Comment:
This had the wrong lifetime specification, which led to weird borrow checker
issues in this PR because the resulting `VariantMetadata` was tied to the
lifetime of `self` instead of `'m`, even if cloned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
