alamb opened a new pull request, #8325:
URL: https://github.com/apache/arrow-rs/pull/8325

   # Which issue does this PR close?
   
   We generally require a GitHub issue to be filed for all bug fixes and 
enhancements and this helps us generate change logs for our releases. You can 
link an issue to this PR using the GitHub syntax.
   
   - Closes https://github.com/apache/arrow-rs/issues/8084
   
   # Rationale for this change
   
   Now that we have merged the upstream parquet-variant tests:
   - https://github.com/apache/parquet-testing/pull/91
   
   We can test how far we are from the rust variant implementation working for 
all the values
   
   This PR updates the test harness added 
https://github.com/apache/arrow-rs/pull/8104 by @carpecodeum  to use the final 
parquet files and the currnet APIs
   
   # What changes are included in this PR?
   
   1. Update parquet-testing pin
   2. Update the test harness to use the standard rust test runner (`#[test]`) 
rather than a custom main function
   3. Added links to follow on tickets
   
   You can run this test manually like this:
   
   ```shell
   cargo test --all-features --test variant_integration
   
   ...
   running 138 tests
   test test_variant_integration_case_106 ... ok
   test test_variant_integration_case_107 ... ok
   test test_variant_integration_case_109 ... ok
   test test_variant_integration_case_110 ... ok
   ..
   test test_variant_integration_case_90 ... ok
   test test_variant_integration_case_91 ... ok
   test test_variant_integration_case_93 ... ok
   test test_variant_integration_case_83 - should panic ... ok
   test test_variant_integration_case_84 - should panic ... ok
   ```
   
   # Are these changes tested?
   Yes this is all tests
   
   # Are there any user-facing changes?
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to