scovich commented on code in PR #8324:
URL: https://github.com/apache/arrow-rs/pull/8324#discussion_r2344603044


##########
parquet-variant-compute/src/variant_array_builder.rs:
##########
@@ -26,27 +26,6 @@ use parquet_variant::{
 use parquet_variant::{ParentState, ValueBuilder, WritableMetadataBuilder};
 use std::sync::Arc;
 
-/// Builder-specific state for array building that manages array-level offsets 
and nulls
-#[derive(Debug)]
-struct ArrayBuilderState<'a> {

Review Comment:
   I just moved this code down to `impl VariantBuilderExt` that actually uses 
it. It seems better to have the actual array builder be the first class defined 
in this module.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to